fix: register ListenerSet and route indexes in offline controller by Aias00 · Pull Request #9320 · envoyproxy/gateway

Aias00 · 2026-06-24T03:20:39Z

Problem

When running Envoy Gateway in standalone (Host) mode with the File provider, the offline controller does not register the gatewayListenerSetIndex field index. This causes repeated errors during Gateway reconciliation:

error provider kubernetes/controller.go:2061 failed to list ListenerSets
  error: "no index with name gatewayListenerSetIndex has been registered
          for GroupVersionKind gateway.networking.k8s.io/v1, Kind=ListenerSet"

The ListenerSet functionality is completely non-functional in standalone mode.

Root Cause

The offline controller (internal/provider/kubernetes/controller_offline.go) used by the File provider was missing several field indexes that the Gateway reconciliation logic depends on. These indexes are registered by the Kubernetes provider in addListenerSetIndexers, addHTTPRouteIndexers, etc., but were not carried over when the offline controller was created for standalone mode.

Changes

`internal/provider/kubernetes/controller_offline.go`

Added 7 missing field indexes to newOfflineGatewayAPIClient:

Index	Type	Purpose
`gatewayListenerSetIndex`	`ListenerSet`	Query ListenerSets by parent Gateway (root cause)
`listenerSetHTTPRouteIndex`	`HTTPRoute`	Query HTTPRoutes by parent ListenerSet
`listenerSetGRPCRouteIndex`	`GRPCRoute`	Query GRPCRoutes by parent ListenerSet
`listenerSetTCPRouteIndex`	`TCPRoute`	Query TCPRoutes by parent ListenerSet
`listenerSetUDPRouteIndex`	`UDPRoute`	Query UDPRoutes by parent ListenerSet
`listenerSetTLSRouteIndex`	`TLSRoute`	Query TLSRoutes by parent ListenerSet
`clusterTrustBundleEepIndex`	`EnvoyExtensionPolicy`	Query EEPs by ClusterTrustBundle ref

`internal/provider/kubernetes/controller_offline_test.go`

Added test coverage for all newly registered indexes in TestNewOfflineGatewayAPIControllerIndexRegistration:

New ListenerSet_index sub-test
Extended HTTPRoute_indices, GRPCRoute_indices, TCPRoute_indices, UDPRoute_indices, TLSRoute_indices, and EnvoyExtensionPolicy_indices sub-tests with listenerSet/clusterTrustBundle index checks

Verification

✅ Unit tests pass (including new ListenerSet_index test)
✅ End-to-end verification: gatewayListenerSetIndex error count drops from multiple-per-reconcile to 0
✅ Build succeeds

Impact

Functionality: ListenerSet now works correctly in standalone mode
Performance: Eliminates repeated error logging on every reconciliation cycle
User Experience: No more confusing error messages for standalone mode users

netlify · 2026-06-24T03:20:44Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`79c0726`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a3c832b505e4b00083d2169
😎 Deploy Preview	https://deploy-preview-9320--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Fixes standalone (Host) mode + File provider reconciliation failures by bringing the offline controller’s fake client field index registrations in sync with what the Kubernetes provider reconciliation logic expects (notably for ListenerSet and ListenerSet-owned routes, plus ClusterTrustBundle refs in EnvoyExtensionPolicy).

Changes:

Register missing field indexes in newOfflineGatewayAPIClient for ListenerSet, ListenerSet-owned Routes, and ClusterTrustBundle refs in EnvoyExtensionPolicy.
Extend offline controller unit tests to assert the new indexes are registered and usable via MatchingFields.

Findings

Required fixes

internal/provider/kubernetes/controller_offline.go:158-162: Add a release note entry to release-notes/current.yaml under bug fixes describing the standalone/offline controller index-registration fix (ListenerSet + related indexes), per repository release note practice.

Optional follow-ups

None.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/provider/kubernetes/controller_offline.go	Registers the missing ListenerSet/ListenerSet-route/ClusterTrustBundle EEP field indexes in the offline fake client.
internal/provider/kubernetes/controller_offline_test.go	Adds/extends unit tests to verify all newly added indexes are registered.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 	return fake.NewClientBuilder().
 		WithScheme(scheme).
 		WithIndex(&gwapiv1.Gateway{}, classGatewayIndex, gatewayIndexFunc).
 		WithIndex(&gwapiv1.Gateway{}, secretGatewayIndex, secretGatewayIndexFunc).
+		WithIndex(&gwapiv1.ListenerSet{}, gatewayListenerSetIndex, gatewayListenerSetIndexFunc).


chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5ed9b34be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-24T03:24:14Z

 		WithScheme(scheme).
 		WithIndex(&gwapiv1.Gateway{}, classGatewayIndex, gatewayIndexFunc).
 		WithIndex(&gwapiv1.Gateway{}, secretGatewayIndex, secretGatewayIndexFunc).
+		WithIndex(&gwapiv1.ListenerSet{}, gatewayListenerSetIndex, gatewayListenerSetIndexFunc).


Store ListenerSets for the file provider

This registers the fake-client index, but in standalone/File mode the objects still never reach that client: user YAML is loaded via loadKubernetesYAMLToResources and persisted via resourcesStore.storeResources, and neither path handles resource.Resources.ListenerSets (I checked internal/provider/file for ListenerSets). With a file containing a ListenerSet, processListenerSets will therefore still list an empty ListenerSetList, so routes/policies attached through the ListenerSet remain non-functional even though the index exists.

Useful? React with 👍 / 👎.

Aias00 · 2026-06-24T03:27:27Z

close: #9319

codecov · 2026-06-24T03:37:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.18%. Comparing base (050c0c5) to head (79c0726).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9320   +/-   ##
=======================================
  Coverage   75.17%   75.18%           
=======================================
  Files         252      252           
  Lines       41049    41056    +7     
=======================================
+ Hits        30857    30866    +9     
  Misses       8095     8095           
+ Partials     2097     2095    -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zirain · 2026-06-24T07:22:15Z

can you fix DCO?

PR envoyproxy#9320 already restores the missing offline controller indexes, but the follow-up review correctly called out that the user-visible fix still needs a release note fragment under the repository's new per-change changelog layout. Constraint: The repository no longer uses release-notes/current.yaml; release notes must be added as current/<section>/<pr-number>-<slug>.md fragments. Rejected: Editing release-notes/current.yaml | the file has been replaced on the PR branch by fragment-based release notes. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep follow-up-only PR fixes constrained to the missing release-note fragment unless a new reviewer finding requires code changes. Tested: bash tools/hack/check-release-notes-filenames.sh; go test ./internal/provider/kubernetes -run TestNewOfflineGatewayAPIControllerIndexRegistration -count=1 Not-tested: Full repository test suite

Aias00 · 2026-06-24T07:25:38Z

can you fix DCO?

yes, I am handling this right now

PR envoyproxy#9320 already restores the missing offline controller indexes, but the follow-up review correctly called out that the user-visible fix still needs a release note fragment under the repository's new per-change changelog layout. Constraint: The repository no longer uses release-notes/current.yaml; release notes must be added as current/<section>/<pr-number>-<slug>.md fragments. Rejected: Editing release-notes/current.yaml | the file has been replaced on the PR branch by fragment-based release notes. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep follow-up-only PR fixes constrained to the missing release-note fragment unless a new reviewer finding requires code changes. Tested: bash tools/hack/check-release-notes-filenames.sh; go test ./internal/provider/kubernetes -run TestNewOfflineGatewayAPIControllerIndexRegistration -count=1 Not-tested: Full repository test suite Signed-off-by: liuhy <liuhongyu@apache.org>

The offline controller used by the File provider was missing several field indexes that the Gateway reconciliation logic depends on. This caused repeated errors during reconciliation: 'failed to list ListenerSets: no index with name gatewayListenerSetIndex has been registered' The following indexes were missing: - gatewayListenerSetIndex on ListenerSet (root cause of the error) - listenerSetHTTPRouteIndex on HTTPRoute - listenerSetGRPCRouteIndex on GRPCRoute - listenerSetTCPRouteIndex on TCPRoute - listenerSetUDPRouteIndex on UDPRoute - listenerSetTLSRouteIndex on TLSRoute - clusterTrustBundleEepIndex on EnvoyExtensionPolicy These indexes are registered by the Kubernetes provider but were not carried over when the offline controller was created for standalone mode. Register them in newOfflineGatewayAPIClient to match the K8s provider setup, and add corresponding test coverage. Fixes: Standalone mode ListenerSet reconciliation errors Signed-off-by: liuhy <liuhongyu@apache.org>

PR envoyproxy#9320 already restores the missing offline controller indexes, but the follow-up review correctly called out that the user-visible fix still needs a release note fragment under the repository's new per-change changelog layout. Constraint: The repository no longer uses release-notes/current.yaml; release notes must be added as current/<section>/<pr-number>-<slug>.md fragments. Rejected: Editing release-notes/current.yaml | the file has been replaced on the PR branch by fragment-based release notes. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep follow-up-only PR fixes constrained to the missing release-note fragment unless a new reviewer finding requires code changes. Tested: bash tools/hack/check-release-notes-filenames.sh; go test ./internal/provider/kubernetes -run TestNewOfflineGatewayAPIControllerIndexRegistration -count=1 Not-tested: Full repository test suite Signed-off-by: liuhy <liuhongyu@apache.org>

The dual-stack UDPRouteBackendFQDNTest reuses the same coredns service hostname that the preceding UDPRoute test deletes and recreates. In CI this can leave Envoy resolving a stale service address from its DNS cache, causing the UDP FQDN backend check to time out for the full poll window even though the route and backend are accepted. Use a dedicated service hostname for the FQDN-specific UDPRoute manifest so the test exercises the intended backend path without inheriting cached DNS state from the previous test. Constraint: The fix must stay within PR envoyproxy#9320 scope and avoid unrelated product-code changes. Rejected: Add sleeps or longer polling to the test | hides the stale-hostname issue without removing the cache collision. Confidence: medium Scope-risk: narrow Reversibility: clean Directive: Keep UDP FQDN backend test hostnames isolated from other UDP backend fixtures when tests create and recreate services in the same namespace. Tested: go test ./e2e/... -run '^$' -tags=e2e (from /test) Not-tested: Full e2e matrix, including v1.35.0 dual-stack runtime execution Signed-off-by: liuhy <liuhongyu@apache.org>

This reverts commit 1426f4f. Signed-off-by: liuhy <liuhongyu@apache.org>

Aias00 · 2026-06-24T11:08:06Z

/retest

Aias00 · 2026-06-25T01:38:26Z

/retest

Aias00 · 2026-06-25T02:21:50Z

/retest

Aias00 · 2026-06-25T03:00:52Z

/retest

Aias00 · 2026-06-25T03:43:45Z

@zirain hi, ci passed, pls take a look

Copilot AI review requested due to automatic review settings June 24, 2026 03:20

Aias00 requested a review from a team as a code owner June 24, 2026 03:20

Copilot started reviewing on behalf of Aias00 June 24, 2026 03:21 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Aias00 force-pushed the worktree-fix-listenerset-offline-index branch from b6740ec to acee7a6 Compare June 24, 2026 07:27

Aias00 added 2 commits June 24, 2026 15:31

Aias00 force-pushed the worktree-fix-listenerset-offline-index branch from 3a88d33 to 5a1e31a Compare June 24, 2026 07:33

Aias00 added 4 commits June 24, 2026 15:33

Merge branch 'main' into worktree-fix-listenerset-offline-index

f654d70

Merge branch 'main' into worktree-fix-listenerset-offline-index

be8a9e6

Revert "Avoid stale DNS cache collisions in UDP FQDN e2e coverage"

a8065ef

This reverts commit 1426f4f. Signed-off-by: liuhy <liuhongyu@apache.org>

Aias00 force-pushed the worktree-fix-listenerset-offline-index branch from 8edbb36 to a8065ef Compare June 24, 2026 09:14

Aias00 added 2 commits June 25, 2026 08:46

Merge branch 'main' into worktree-fix-listenerset-offline-index

c1d22fb

Merge branch 'main' into worktree-fix-listenerset-offline-index

79c0726

zirain approved these changes Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

Aias00 commented Jun 24, 2026

Problem

Root Cause

Changes

internal/provider/kubernetes/controller_offline.go

internal/provider/kubernetes/controller_offline_test.go

Verification

Impact

Uh oh!

netlify Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Findings

Reviewed changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Aias00 commented Jun 24, 2026

Uh oh!

codecov Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zirain commented Jun 24, 2026

Uh oh!

Aias00 commented Jun 24, 2026

Uh oh!

Aias00 commented Jun 24, 2026

Uh oh!

Aias00 commented Jun 25, 2026

Uh oh!

Aias00 commented Jun 25, 2026

Uh oh!

Aias00 commented Jun 25, 2026

Uh oh!

Aias00 commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`internal/provider/kubernetes/controller_offline.go`

`internal/provider/kubernetes/controller_offline_test.go`

netlify Bot commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jun 24, 2026 •

edited

Loading